-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phantom types: add most missing flexbox functions/values #452
Conversation
4b6436b
to
0cb9289
Compare
src/Css.elm
Outdated
flexWrap noWrap | ||
|
||
-} | ||
noWrap : Value { provides | noWrap : Supported } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! nowrap
is all lowercase as a value. Should we be consistent with the values and make this also all lowercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, nowrap
already existed for white-space
(I missed it), so I removed noWrap
and added an example in nowrap
.
Thank you!
0cb9289
to
1ef0ef6
Compare
Hi, first PR here so feedback is welcome.
Important notes / feedback likely needed
displayFlex
bydisplay flex_
as it seems thatunderscore
won the namespace war for now. Tell me if I'm wrong.alignItems
andall
(in passing) as they seemed wrong (their value record was parameterized onaccepts
). But I may have misunderstood something so tell me if I should remove this modification.justifyContent
andalignContent
as they are still in a draft specification and are not well supported by all browsers. HoweveralignItems
already implements them partially (overflow alignment is limited tosafe center
orunsafe center
butcenter | start | end | self-start | self-end | flex-start | flex-end
should also be valid). So I need feedback to know what to do.min-content
,max-content
, ...) forflexBasis
for the same reasons. However they are listed in the phantom-types issue, so I'm not really sure what we want.Other less important notes
flexFlow1
(in the listed function to implement) toflexFlow
as it seemed more consistent with other multiple values functionsunderscore
in the source. I choose what seemed the best but a pass to harmonize them is most likely needed at the end.Thank you very much for this library.
Regards