Fix SvgKeyed #520
Merged
Fix SvgKeyed #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvgKeyed used keyedNode instead of keyedNodeNS. The virtual DOM therefore treated the Svg as a generic element. The fix reflects the fix made by Evan in the elm/svg package. https://github.com/elm/svg/blob/master/src/Svg/Keyed.elm
|
Hey @rtfeldman, a bump for the PR. I am able to self publish a version myself in the mean time, thought I shall try a bump first. Also, on an unrelated note, thank you for all the resources and learning material you publish within the elm community. I watched quite a few of your talks and read bits and pieces of your book. |
|
Thanks! This looks fine. Sorry I took so long getting to this! |
|
Published as 16.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvgKeyed used keyedNode instead of keyedNodeNS. The virtual DOM
therefore treated the Svg as a generic element.
The fix reflects the fix made by Evan in the elm/svg package.
https://github.com/elm/svg/blob/master/src/Svg/Keyed.elm
Also, this closes issue #504.
The fix originated from a Keyed Svg of mine that contained no width or height. I noticed that the browser treated it as a generic node instead of an Svg. I compared rtfeldman/elm-css to elm/svg and noticed the difference.