Add errors with explanation for the removed options warn and pathToMake #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeue56
approved these changes
Aug 28, 2018
|
Found the problem will add another commit soon |
eeue56
reviewed
Aug 28, 2018
index.js
Outdated
| @@ -75,8 +75,10 @@ function compilerErrorToString(err, pathToElm) { | |||
| default: | |||
| return ("Error attempting to run Elm compiler \"" + pathToElm + "\":\n" + err); | |||
| } | |||
| } else if ((typeof err === "object") && (typeof err.message === "string")) { | |||
| return (JSON.stringify(err.message)); | |||
There was a problem hiding this comment.
no need for () around JSON.stringify(err.message) here
eeue56
reviewed
Aug 28, 2018
index.js
Outdated
| } else { | ||
| return ("Exception thrown when attempting to run Elm compiler " + JSON.stringify(pathToElm) + ":\n"); | ||
| return ("Exception thrown when attempting to run Elm compiler " + JSON.stringify(pathToElm)); |
razzeee
force-pushed
the
report-missing-deprecated-params
branch
from
b6c187a to
46008dd
Compare
|
Love it, thank you @razzeee! |
|
Published as 5.0.1. |
|
Thanks for the quick feedback loop :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should report helpful errors when using the warn or pathToMake option.
I tried to test it, but still get this error: