Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only display "Viewed" checkbox if fileContentToggle is set #366

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

Pierrci
Copy link
Contributor

@Pierrci Pierrci commented Mar 1, 2021

Currently the "Viewed" checkbox introduced in #358 is displayed even if fileContentToggle is not set or false. This PR fixes this behavior so that the checkbox is only displayed if fileContentToggle is true.

As a result, also fixes #364.

Copy link
Owner

@rtfpessoa rtfpessoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution

@rtfpessoa rtfpessoa merged commit e55d145 into rtfpessoa:master Mar 4, 2021
@rtfpessoa
Copy link
Owner

@Pierrci Pierrci deleted the fix-viewed-checkbox branch March 11, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File content toggle (checkbox) should not be rendered when using Diff2Html only
2 participants