Tokenizers dispatch in vectorizers #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
changed the title
|
Tokenizer dispatch should now work in vectorizers in Rust. Though in view of PyO3/pyo3#503 it's still unclear how to allow changing the tokenizer on the Python side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #48, allows to select the tokenizer used in vectorizers.
As mentioned in #48 (comment) this will require PyO3 O.7.0 that includes PyO3/pyo3#461 (hopefully released in the coming days) or a way to avoid using explicitly defined lifetimes in python wrapper methods for vectorizers.