Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout in async and sync DoH query #1155

Closed
wants to merge 1 commit into from
Closed

Fix timeout in async and sync DoH query #1155

wants to merge 1 commit into from

Commits on Oct 24, 2024

  1. Fix timeout in async and sync DoH query 

    Fixes rthalley#978

Add timeout handling to `dns.asyncquery.https` function to prevent hanging on non-DoH servers.

* Modify `dns/asyncquery.py` to use `asyncio.wait_for` in the `https` function to enforce the timeout.
* Update `tests/test_query.py` to include a test case for the timeout behavior in `dns.asyncquery.https`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/rthalley/dnspython/issues/978?shareId=XXXX-XXXX-XXXX-XXXX).
    @mustafacco7
    mustafacco7 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8abc476 View commit details
    Browse the repository at this point in the history