Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Repository #139

Open
rthaut opened this issue May 19, 2020 · 2 comments
Open

Rename Repository #139

rthaut opened this issue May 19, 2020 · 2 comments

Comments

@rthaut
Copy link
Owner

rthaut commented May 19, 2020

When this extension was first created, deviantart.com was branded as "deviantART," so I adopted that naming convention. At some point later on they switched to "DeviantArt," and I eventually renamed the extension to match.

However, I never renamed this repository. While renaming repositories on GitHub is trivial, Project Page URLs are not automatically redirected. Additionally, the URLs are case-sensitive (since they are served as a sub-path), so https://rthaut.github.io/deviantART-Filter/ and https://rthaut.github.io/DeviantArt-Filter/ and https://rthaut.github.io/deviantart-filter/ are all different.

In order to rename the repository, I will either need to first have a redirect mechanism in place (or have it ready to deploy immediately), or will have to live with the possibility of broken links pointed at the old URL.

@rthaut
Copy link
Owner Author

rthaut commented May 19, 2020

This was actually an easy fix; I just followed the instructions in this gist.

The redirect file is here: rthaut/rthaut.github.io/blob/master/deviantART-Filter/index.html

I will still make attempts to update links everywhere I can, but I think this can be closed now.

@rthaut rthaut closed this as completed May 19, 2020
rthaut added a commit that referenced this issue May 19, 2020
@rthaut
Copy link
Owner Author

rthaut commented May 19, 2020

The redirect method I used only handles requests to the root of the Project Page, but not for any other pages/paths.

This caused problems for users upgrading to v6.1.0, which opens the Release page for that version, but was not correctly redirected.

@rthaut rthaut reopened this May 19, 2020
@rthaut rthaut changed the title Rename Repository ("deviantART-Filter" to "DeviantArt-Filter") Rename Repository May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant