Improve HeartBeat and ACKNACK messages and fix minor issues #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 11, 2016 13:16
The algorithm get the name of a entity GUID was returning in some cases INVALID or the wrong entity ID. Sometimes, two different entities were referred with the same name.
The messages are a little bit longer to explain the meaning of the interval (samples in that interval). I have also improved a regular expression to match more logs and split a log into another function to add information.
iblancasa
suggested changes
Dec 19, 2016
| try: | ||
| print(text) | ||
| except IOError: | ||
| # It makes no sense to print the error since we already had |
There was a problem hiding this comment.
Are we printing where the exception is happening?
There was a problem hiding this comment.
The exception happens in the native print operation because the pipe is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This branch contains changes from the fix_guids branch. Please, don't review this PR until #10 is accepted and merged into master
I have improved the messages related to HeartBeat and ACK/NACK messages to be more descriptive and easy to read.
I have fixed to minor unrelated issues:
--onlyand--highlightargument were not working.