Fix parser stopped to read input after empty line #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the parser found an empty line it stopped reading more input. The issue was that empty lines and EOF were similar. As an empty line contains the new line characters (\n, \r\n), we are using them to distinguish these two situations. The fix applies to the InputFileDevice and InputConsoleDevice. Fixes #16
iblancasa
suggested changes
Dec 27, 2016
| line = True # For the first condition. | ||
| while line: | ||
| line = "" | ||
| while line is not None: |
There was a problem hiding this comment.
Why? It should be:
while line:There was a problem hiding this comment.
Because then line == "" will be false too and don't want to stop for empty lines.
| line = device.read_line() | ||
|
|
||
| # Remove end of lines | ||
| if line: |
There was a problem hiding this comment.
You first check "if line". Then "if not line" and then you only continues with this iteration if line...
There was a problem hiding this comment.
This is because we want to remove new line chars only when line is not None and we don't want to set line to an empty string to distinguish between empty line and EOF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parser found an empty line it stopped reading more
input. The issue was that empty lines and EOF were similar.
As an empty line contains the new line characters (\n, \r\n),
we are using them to distinguish these two situations. The fix
applies to the InputFileDevice and InputConsoleDevice.
Fixes #16