Fix crash when parsing empty files #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
suggested changes
Dec 14, 2016
| @@ -124,6 +124,9 @@ def print_progress(self, threshold=0, decimals=1, barLength=100): | |||
| # Based on @Greenstick's reply (https://stackoverflow.com/a/34325723) | |||
| iteration = self.stream.tell() | |||
| total = self.file_size | |||
| if total == 0: | |||
| return | |||
|
|
|||
| progress = 100.0 * iteration / total | |||
| if self.progress > 0 and progress - self.progress < threshold: | |||
There was a problem hiding this comment.
if self.progress > 0Should be
if self.progress| @@ -124,6 +124,9 @@ def print_progress(self, threshold=0, decimals=1, barLength=100): | |||
| # Based on @Greenstick's reply (https://stackoverflow.com/a/34325723) | |||
| iteration = self.stream.tell() | |||
| total = self.file_size | |||
| if total == 0: | |||
There was a problem hiding this comment.
I think that this should be:
if not total:But this is not enough intuitive. What do you think?
There was a problem hiding this comment.
I think that reading "if not total" is not intuitive. It make sense to compare against 0.
iblancasa
approved these changes
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script crashes when the user tried to give as input an empty file.
I have also fix some links in the Messages.md file and add two command line commands to increase verbosity from the command line in Windows and with tcsh.