Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid propagation of properties #228

Merged
merged 2 commits into from
Sep 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions srcCpp03/RTIDDSImpl.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -1688,8 +1688,7 @@ bool RTIDDSImpl<T>::Initialize(ParameterManager &PM, perftest_cpp *parent)
//We have to copy the properties to the participant_qos object
qos << rti::core::policy::Property(
properties.begin(),
properties.end(),
true);
properties.end());

DomainListener *listener = new DomainListener;

Expand Down Expand Up @@ -2225,7 +2224,7 @@ dds::sub::qos::DataReaderQos RTIDDSImpl<T>::setup_DR_QoS(
dr_qos << qos_durability;
dr_qos << dr_DataReaderProtocol;
dr_qos << qos_dr_resource_limits;
dr_qos << Property(properties.begin(), properties.end(), true);
dr_qos << Property(properties.begin(), properties.end());

return dr_qos;
}
Expand Down Expand Up @@ -2508,7 +2507,7 @@ dds::pub::qos::DataWriterQos RTIDDSImpl<T>::setup_DW_QoS(
dw_qos << dwBatch;
dw_dataWriterProtocol.rtps_reliable_writer(dw_reliableWriterProtocol);
dw_qos << dw_dataWriterProtocol;
dw_qos << Property(properties.begin(), properties.end(), true);
dw_qos << Property(properties.begin(), properties.end());

return dw_qos;
}
Expand Down
9 changes: 9 additions & 0 deletions srcDoc/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ What's New in Master
What's Fixed in Master
~~~~~~~~~~~~~~~~~~~~~~

Participant properties always propagate in C++03 (#228)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

QoS properties for Data Readers and Data Writers were being propagated on C++03
implementation.

This behavious is not needed so has been removed to behave as on Traditional C++.


Improve message when NDDSHOME/RTIMEHOME paths are not reachable (#222)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down