This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Enhance/fetch base query #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 066032c:
|
msutkowski
force-pushed
the
enhance/fetch-base-query
branch
2 times, most recently
from
93cfcc6
to
fe43058
Compare
phryneas
reviewed
Nov 7, 2020
phryneas
reviewed
Nov 7, 2020
phryneas
reviewed
Nov 7, 2020
phryneas
reviewed
Nov 7, 2020
phryneas
reviewed
Nov 7, 2020
phryneas
reviewed
Nov 7, 2020
|
looking good so far, nothing to critizise really, I just commented on some nitpicks :) |
msutkowski
force-pushed
the
enhance/fetch-base-query
branch
from
3c19c7e
to
409650d
Compare
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
msutkowski
force-pushed
the
enhance/fetch-base-query
branch
from
e55cfca
to
8ecea84
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP, but it's getting there. Will add further notes tomorrow.