str2str readcmd: avoid constant sizes #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ourairquality
force-pushed
the
str2str-readcmd
branch
from
9adc78a to
cb497dc
Compare
MAXSTR was not the appropriate definition of the buffer size here as it is the number of streams which is distinct from the command line read chunk size. Use a read chuck size of 81 characters. Pass in the target cmd size, rather than depending on MAXRCVCMD. Exit as soon as the target is full, rather than filling with smaller later chucks, and emit a warning on overflow. Only accept the separator character @ at the start of a line and flush to the end of this line.
ourairquality
force-pushed
the
str2str-readcmd
branch
from
cb497dc to
cf4ab29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAXSTR was not the appropriate definition of the buffer size here as it is the number of streams which is distinct from the command line read chunk size. Use a read chuck size of 81 characters.
Pass in the target cmd size, rather than depending on MAXRCVCMD.
Exit as soon as the target is full, rather than filling with smaller later chucks, and emit a warning on overflow.