Redis credentials #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
* Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Update README.md * Update README.md * Create USERS.md
|
Will this change also work if you deploy the application along with a redis instance on kubernetes via the helm chart? So if you deploy with |
|
Yes, it should. The helm chart is able to deploy a local |
|
Okido good, LGTM then! 👍 |
nielstenboom
approved these changes
Oct 28, 2020
spaghettifunk
added a commit
that referenced
this pull request
Nov 2, 2020
* Update README.md * Redis credentials (#44) * Update issue templates * OSS (#42) * removing sensitive information for opensourcing the project * add chart for deploying phoenix * remove hardcoded port * Update README.md * Create docker-publish.yml * Update README.md * Update README.md * Create LICENSE * Update README.md * Guidelines (#43) * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Update README.md * Update README.md * Create USERS.md * Update README.md * Update README.md * bump redis client version, add DB_PASSWORD for redis password, fix worker queue * typo in error checking * add new ENV to chart Co-authored-by: Niels ten Boom <nielstenboom@gmail.com> * remove default password from tests and cli Co-authored-by: Niels ten Boom <nielstenboom@gmail.com>
csimplestring
added a commit
that referenced
this pull request
Aug 3, 2021
* Development (#45) * Update README.md * Redis credentials (#44) * Update issue templates * OSS (#42) * removing sensitive information for opensourcing the project * add chart for deploying phoenix * remove hardcoded port * Update README.md * Create docker-publish.yml * Update README.md * Update README.md * Create LICENSE * Update README.md * Guidelines (#43) * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Update README.md * Update README.md * Create USERS.md * Update README.md * Update README.md * bump redis client version, add DB_PASSWORD for redis password, fix worker queue * typo in error checking * add new ENV to chart Co-authored-by: Niels ten Boom <nielstenboom@gmail.com> * remove default password from tests and cli Co-authored-by: Niels ten Boom <nielstenboom@gmail.com> * Bugfix chart (#46) * add missing nodeselectors + fixed wrong refs * proper line endings * bumbing up versions to remove vulnerabilites * pinning alpine image to 3.13 Co-authored-by: Davide Berdin <davideberdin@gmail.com> Co-authored-by: Niels ten Boom <nielstenboom@gmail.com> Co-authored-by: Yi Wang <yi.wang@rtl.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
DB_PASSWORDfor redis password