Skip to content
This repository has been archived by the owner on Oct 16, 2018. It is now read-only.

Commit

Permalink
Bump apache http library version and remove deprecated stale connecti…
Browse files Browse the repository at this point in the history
…on check configuration
  • Loading branch information
rveitch committed Apr 28, 2015
1 parent cc2c37f commit 49f5272
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,9 @@ public Double read(JsonReader in) throws IOException {
new CustomHttpRequestRetryHandler(this.retryCount, this.requestSentRetry))
.setRedirectStrategy(new CustomRedirectStrategy())
.setDefaultRequestConfig(
RequestConfig.custom()
.setExpectContinueEnabled(this.expectContinue)
// TODO investigate performance impact of stale check (30ms reported)
.setStaleConnectionCheckEnabled(true).setRedirectsEnabled(true)
.setRelativeRedirectsAllowed(true).setConnectTimeout(this.connectTimeout)
.setSocketTimeout(this.soTimeout)
RequestConfig.custom().setExpectContinueEnabled(this.expectContinue)
.setRedirectsEnabled(true).setRelativeRedirectsAllowed(true)
.setConnectTimeout(this.connectTimeout).setSocketTimeout(this.soTimeout)
// TODO should this be infinite? length of time allowed to request a connection
// from the pool
.setConnectionRequestTimeout(0).build()).build();
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>4.3.5</version>
<version>4.4.1</version>
</dependency>
<dependency>
<groupId>com.github.tomakehurst</groupId>
Expand Down

0 comments on commit 49f5272

Please sign in to comment.