Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline/state #96

Merged
merged 44 commits into from
Mar 27, 2024
Merged

Pipeline/state #96

merged 44 commits into from
Mar 27, 2024

Conversation

retailcoder
Copy link
Member

@retailcoder retailcoder commented Mar 11, 2024

Objectives:

  • Get editor/client to communicate with language server on change/open/closed/etc.
  • Get syntax errors and diagnostics to appear as text markers (/squiggles)
  • Get markers to render an actionable icon/menu ("ducky button") in a dedicated marker margin
  • Get document diagnostics and foldings to refresh correctly
  • Adjust idle timer default, make configurable

@retailcoder retailcoder marked this pull request as ready for review March 27, 2024 02:33
@retailcoder
Copy link
Member Author

retailcoder commented Mar 27, 2024

Doesn't quite refresh correctly, but there's back-and-forth going on between the editor and the server when a code document is modified, and that's what I wanted to see at this stage.

Margin displays an appropriate icon for diagnostics, but icon isn't actionable. Text markers clear correctly on change, but not the icons in the margin, and foldings do not seem to load consistently - possible race condition in state assignment.

@retailcoder retailcoder merged commit 5b3caf6 into rubberduck-vba:main Mar 27, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant