Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect BMP and TIFF image size #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kikihakiem
Copy link

@kikihakiem kikihakiem commented Nov 11, 2019

This change is Reviewable

@kikihakiem
Copy link
Author

kikihakiem commented Nov 11, 2019

It's weird it fails with go1.4 in travis. When I run test with go1.4 in my local, all tests passed

$ docker run --rm -v "$PWD":/go/src/github.com/rubenfonseca/fastimage -w /go/src/github.com/rubenfonseca/fastimage golang:1.4-alpine go version && go test ./...
go version go1.4.3 linux/amd64
ok      github.com/rubenfonseca/fastimage       2.143s

Edit: the issue was because cached response, so whichever test come later, it will use cached response from earlier test, resulting no timeout. That also explains why there's only 1 passed test matrix.

@kikihakiem kikihakiem force-pushed the detect-bmp-tiff-size branch from b0439e5 to ee598f4 Compare April 18, 2020 09:30
@kikihakiem kikihakiem changed the title Detect bmp image size Detect BMP and TIFF image size Apr 18, 2020
@kikihakiem kikihakiem force-pushed the detect-bmp-tiff-size branch from ee598f4 to 6746a9c Compare April 18, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant