Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dselans/concurrency support #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dselans/concurrency support #58

wants to merge 2 commits into from

Commits on Feb 20, 2017

  1. Adding support for concurrent sql-migrate usage (via lib) 

    - Introduced two new funcs: `ExecMaxWithLock()` and `ExecWithLock`
- Use a db-based mutex (to avoid getting locked into supporting vendor-specific lock implementations)
- I was getting 'database is locked' errors when writing tests using sqlite3 -- this appears to be normal (?) behavior due to sqlite and concurrent access; added an additional test suite specifically most 'mysql', which worked as expected.
- Exposed a test flags `-enable-mysql` (default: false) and `-disable-sqlite` (default: false)
    @dselans
    dselans committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    d0c4607 View commit details
    Browse the repository at this point in the history

  2. Forgot to update .travis to enable mysql-based tests

    @dselans
    dselans committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    20bd19e View commit details
    Browse the repository at this point in the history