-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sender signature details in block #144
Merged
thewebchap
merged 38 commits into
development
from
maneesha/sender-signature-in-block-with-signVersion
May 24, 2024
Merged
Adding sender signature details in block #144
thewebchap
merged 38 commits into
development
from
maneesha/sender-signature-in-block-with-signVersion
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error while parsing the json file . Can you make sure it's in proper json format? P.S : I think this is an existing issue predating this PR. |
maneeSHA-256
force-pushed
the
maneesha/sender-signature-in-block-with-signVersion
branch
from
May 22, 2024 05:37
8bad32c
to
bd7b94c
Compare
… test workflow to upload the node logs as artifacts in Github Action sessions
…ction to happen successfully
…run_non_quorum_nodes is removed
fixed |
thewebchap
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we are adding sender signature details to the token chain block where the details include the following fields:
1, if signed using NLSS signing scheme
The numeral key assigned to the Sender Signature filed is "12". Shown below are the structures of a block in a dumped token chain with sender signature filed in two different scenarios.
Basic mode sender did with NLSS signature:
Light mode sender did with BIP signature: