-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of cobra
package to refactor CLI
#172
Draft
arnabghose997
wants to merge
29
commits into
development
Choose a base branch
from
arnab/cli-refactor
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in() for clean concatenation of directory and file paths
arnabghose997
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
NOTE: Must be merged only after PR #190 is merged
This PR intends to refactor the existing CLI by using the
cobra
CLI Golang package. Refer here for details of cobra package.Refer here for the CLI documentation
Following are key highlights of this PR:
Command
struct has been renamed toCommandConfig
in order to avoid confusion with theCommand
struct ofcobra
package.--
) instead of single hyphen (-
). Flag names are have not been changed. Ever command now displays only those flags which are associated with their operation.addr
andport
are the only Global flags because of their usage in almost every command.path.Join()
has been used, instead simple+
operation, for cleaner file path concatenation.-grpcPort
flag has been removed from commands wherever it is not required.