fix: distributed pledging exit when quorum count is <7 #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #173 when
noBalanceQuorumCount
check is done with quorum count 5 or 6.Explanation
noBalanceQuorumCount
is initialised to zero and incremented each time a quorum doesn't have enough tokens to pledge. Rubix PBFT consensus requires 5 nodes to pledge and hence as soon asnoBalanceQuorumCount
reaches greater than 2 , sender exit. The problem is when there are only 5 or 6 quorum nodes where in such situtaions , we should exit as soon as we realise we will not have 5 nodes that can pledge. Currently the sender wait 300 seconds before exiting with a different error code.Fix
Initialise
noBalanceQuorumCount
toQuorumRequired - len(cr.QuorumList)
PS : Also renaming
quorumCount
in quorum.go toquorumAddrCount
to avoid naming confusion.