code review changes

app/controllers/api/action_items_controller.rb

@@ -25,31 +25,31 @@ def destroy
 
     def move
       if @action_item.move!(@board)
-        head :no_content
+        head :ok
       else
         render json: { error: @action_item.errors.full_messages.join(',') }, status: :bad_request
       end
     end
 
     def close
       if @action_item.close!
-        head :no_content
+        head :ok
       else
         render json: { error: @action_item.errors.full_messages.join(',') }, status: :bad_request
       end
     end
 
     def complete
       if @action_item.complete!
-        head :no_content
+        head :ok
       else
         render json: { error: @action_item.errors.full_messages.join(',') }, status: :bad_request
       end
     end
 
     def reopen
       if @action_item.reopen!
-        head :no_content
+        head :ok
       else
         render json: { error: @action_item.errors.full_messages.join(',') }, status: :bad_request
       end

app/javascript/components/ActionItem/ActionItemFooter/index.js

@@ -37,7 +37,7 @@ class ActionItemFooter extends React.Component {
         'X-CSRF-Token': document.querySelector("meta[name='csrf-token']").getAttribute('content')
       }
     }).then((result) => {
-      if (result.status == 204) {
+      if (result.status == 200) {
         window.location.reload();
       }
       else { throw result }

app/javascript/components/ActionItem/TransitionButton/index.js

@@ -1,7 +1,5 @@
 import React from "react"
 
-import "./TransitionButton.css"
-
 class TransitionButton extends React.Component {
   constructor(props) {
     super(props)
@@ -17,8 +15,7 @@ class TransitionButton extends React.Component {
         'X-CSRF-Token': document.querySelector("meta[name='csrf-token']").getAttribute('content')
       }
     }).then((result) => {
-      if (result.status == 204) {
-        console.log(`doing ${this.props.action}!!!`)
+      if (result.status == 200) {
         window.location.reload();
       }
       else { throw result }

db/migrate/20191017083034_add_times_moved_to_action_items.rb

@@ -2,6 +2,6 @@
 
 class AddTimesMovedToActionItems < ActiveRecord::Migration[6.0]
   def change
-    add_column :action_items, :times_moved, :integer, default: 0
+    add_column :action_items, :times_moved, :integer, default: 0, null: false
   end
 end

db/schema.rb

@@ -21,7 +21,7 @@
     t.string "status", default: "pending", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
-    t.integer "times_moved", default: 0
+    t.integer "times_moved", default: 0, null: false
     t.index ["board_id"], name: "index_action_items_on_board_id"
   end
 

spec/controllers/api/action_items_controller_spec.rb

@@ -111,7 +111,7 @@
         allow(action_item).to receive(:move!).with(board).and_return(true)
       end
 
-      it_behaves_like :controllers_api_successful_action, :no_content
+      it_behaves_like :controllers_api_successful_action
     end
   end
 
@@ -144,7 +144,7 @@
         allow(action_item).to receive(:close!).and_return(true)
       end
 
-      it_behaves_like :controllers_api_successful_action, :no_content
+      it_behaves_like :controllers_api_successful_action
     end
   end
 
@@ -177,7 +177,7 @@
         allow(action_item).to receive(:complete!).and_return(true)
       end
 
-      it_behaves_like :controllers_api_successful_action, :no_content
+      it_behaves_like :controllers_api_successful_action
     end
   end
 
@@ -210,7 +210,7 @@
         allow(action_item).to receive(:reopen!).and_return(true)
       end
 
-      it_behaves_like :controllers_api_successful_action, :no_content
+      it_behaves_like :controllers_api_successful_action
     end
   end
 end