Elizaveta Shved - 0 #38

elishved · 2018-12-09T21:58:12Z

Name

Elizaveta Shved

Homework#

0

Comment

Level 1, 2 and 3.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .ruboc...

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .rubocop.yml Warning: unrecognized cop Style/MethodMissingSuper found in .rubocop.yml Warning: unrecognized cop Style/MissingRespondToMissing found in .rubocop.yml incompatible character encodings: UTF-8 and ASCII-8BIT /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:135:in `file_checksum' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:85:in `initialize' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `new' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `file_offense_cache' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:109:in `file_offenses' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:100:in `process_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:78:in `block in each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `reduce' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:67:in `inspect_files' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:39:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:156:in `execute_runner' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:84:in `execute_runners' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:41:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:13:in `block in ' /usr/lib/ruby/2.5.0/benchmark.rb:308:in `realtime' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:12:in `' /home/linters/.bundle/bin/rubocop:23:in `load' /home/linters/.bundle/bin/rubocop:23:in `' Inspecting 1 file

0 files inspected, no offenses detected

Елизавета Швед/Елизавета Швед : 0/run.rb

Елизавета Швед/Елизавета Швед : 0/download_sheets.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .ruboc...

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .rubocop.yml Warning: unrecognized cop Style/MethodMissingSuper found in .rubocop.yml Warning: unrecognized cop Style/MissingRespondToMissing found in .rubocop.yml incompatible character encodings: UTF-8 and ASCII-8BIT /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:135:in `file_checksum' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:85:in `initialize' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `new' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `file_offense_cache' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:109:in `file_offenses' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:100:in `process_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:78:in `block in each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `reduce' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:67:in `inspect_files' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:39:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:156:in `execute_runner' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:84:in `execute_runners' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:41:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:13:in `block in ' /usr/lib/ruby/2.5.0/benchmark.rb:308:in `realtime' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:12:in `' /home/linters/.bundle/bin/rubocop:23:in `load' /home/linters/.bundle/bin/rubocop:23:in `' Inspecting 1 file

0 files inspected, no offenses detected

Елизавета Швед/Елизавета Швед - 0/run.rb

Елизавета Швед/Елизавета Швед - 0/download_sheets.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

elizaveta_shved/elizaaveta_shved_0/run.rb

elizaveta_shved/elizaaveta_shved_0/download_sheets.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Елизавета Швед/Елизавета Швед - 0/download_sheets.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .ruboc...

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .rubocop.yml Warning: unrecognized cop Style/MethodMissingSuper found in .rubocop.yml Warning: unrecognized cop Style/MissingRespondToMissing found in .rubocop.yml incompatible character encodings: UTF-8 and ASCII-8BIT /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:135:in `file_checksum' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:85:in `initialize' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `new' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `file_offense_cache' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:109:in `file_offenses' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:100:in `process_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:78:in `block in each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `reduce' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:67:in `inspect_files' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:39:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:156:in `execute_runner' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:84:in `execute_runners' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:41:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:13:in `block in ' /usr/lib/ruby/2.5.0/benchmark.rb:308:in `realtime' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:12:in `' /home/linters/.bundle/bin/rubocop:23:in `load' /home/linters/.bundle/bin/rubocop:23:in `' Inspecting 1 file

0 files inspected, no offenses detected

Елизавета Швед/Елизавета Швед - 0/download_sheets.rb

Елизавета Швед/Елизавета Швед - 0/db_requester.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .ruboc...

Warning: unrecognized cop Naming/UncommunicativeMethodArgName found in .rubocop.yml Warning: unrecognized cop Style/MethodMissingSuper found in .rubocop.yml Warning: unrecognized cop Style/MissingRespondToMissing found in .rubocop.yml incompatible character encodings: UTF-8 and ASCII-8BIT /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:135:in `file_checksum' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/result_cache.rb:85:in `initialize' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `new' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:117:in `file_offense_cache' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:109:in `file_offenses' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:100:in `process_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:78:in `block in each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `reduce' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each_inspected_file' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:67:in `inspect_files' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/runner.rb:39:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:156:in `execute_runner' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:84:in `execute_runners' /home/linters/.bundle/gems/rubocop-0.54.0/lib/rubocop/cli.rb:41:in `run' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:13:in `block in ' /usr/lib/ruby/2.5.0/benchmark.rb:308:in `realtime' /home/linters/.bundle/gems/rubocop-0.54.0/bin/rubocop:12:in `' /home/linters/.bundle/bin/rubocop:23:in `load' /home/linters/.bundle/bin/rubocop:23:in `' Inspecting 1 file

0 files inspected, no offenses detected

Елизавета Швед/Елизавета Швед - 0/db_requester.rb

elizaveta_shved/elizaaveta_shved_0/data_parser.rb

RGBD

Решение использовать sqlite - супер 👏
Структура папок: Имя Фамилия/Номер/.

RGBD · 2018-12-10T06:46:30Z

Елизавета Швед/Елизавета Швед - 0/download_sheets.rb

+    end
+  end
+
+  def generate_links_2009


Упрости загрузку страниц. Есть Nokogiri, спомощью которого можно скачать и распарсить главную страницу белстата, получить все ссылки на файлы, а потом по скачанным файлам восстановить даты.
Плохо, что есть куча методов, которые возвращают список ссылок.
Также можно создать json файл информацией о ссылках на документы и датах, прочитать его, и скачать указанные там файлы.

RGBD · 2018-12-10T06:49:21Z

Елизавета Швед/Елизавета Швед - 0/download_sheets.rb

+  def download_file(date, link, type)
+    response = Faraday.get(link)
+    begin
+      file = File.open("./data/#{date}.#{type}", "w")


Если можно избежать явного открытия файла, стоит так сделать
варианты:

File.open(...) do |file| file.write... end

или

File.write(filename, response.body)

RGBD · 2018-12-10T06:55:23Z

Елизавета Швед/Елизавета Швед - 0/run.rb

+
+  def check_data
+    File.new('test.db', 'a')
+    @db = SQLite3::Database.open 'test.db'


раз создаётся test.rb он должен быть добавлен в .gitignore

RGBD · 2018-12-10T07:06:47Z

Елизавета Швед/Елизавета Швед - 0/run.rb

+class Waiter
+  def check_files
+    FileUtils.mkdir_p './data'
+    Dir['./data/*.*'].count < 100 ? DownloadSheets.new.perform_data : true


100 стоит вынести в константу, если это точное число файлов.
Поскольку perform_data возвращает 10, предполагаю что результат этого метода не важен.
Можно заменить на
DownloadSheets.new.perform_data if count < 100

RGBD · 2018-12-10T07:11:34Z

elizaveta_shved/elizaaveta_shved_0/data_parser.rb

+        mogilev_region = mogilev_region / AMOUNT_FOR_DENOMOZATION if !mogilev_region.nil?
+      end
+
+      @db.execute "INSERT INTO Items (name, region, price, date) VALUES('#{product_name}','Брестская область',#{brest_region}, #{date})"


Сделай цикл по именам областей, имена областей вынеси в константу.

RGBD · 2018-12-10T07:11:51Z

elizaveta_shved/elizaaveta_shved_0/data_parser.rb

+      mogilev_region = row[18]
+
+      if date < DATE_FOR_DENOMIZATION
+        brest_region = brest_region / AMOUNT_FOR_DENOMOZATION if !brest_region.nil?


Сделай цикл по именам областей.

Evshved · 2018-12-10T14:37:22Z

Елизавета Швед/Елизавета Швед - 0/download_sheets.rb

@@ -0,0 +1,168 @@
+require 'rubygems'


What about gemfile?

Evshved · 2018-12-10T14:37:28Z

Елизавета Швед/Елизавета Швед - 0/data_parser.rb

+    next unless check_data
+      product_name = row[0].downcase
+      brest_region = row[6]
+      vitebsk_region = row[8]


Add indexes to constants.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta_Shved/Elizaveta Shved : 0 :/download_sheets.rb

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

RGBD · 2018-12-28T06:51:26Z

Please, fix rubocop issues

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta_Shved/Elizaveta Shved : 0 :/download_sheets.rb

houndci-bot · 2019-01-01T21:12:34Z

Elizaveta_Shved/Elizaveta Shved : 0 :/download_sheets.rb

+    URI.encode(link)
+  end
+
+  def get_data


Metrics/MethodLength: Method has too many lines. [11/10]
Naming/AccessorMethodName: Do not prefix reader method names with get_.

Elizaveta_Shved/Elizaveta Shved : 0 :/download_sheets.rb

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

RGBD · 2019-01-07T08:30:58Z

Please fix rubocop issues

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

elishved · 2019-01-09T22:23:46Z

@RGBD, please review my pr

RGBD · 2019-01-07T08:34:13Z

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

+    (9..table.last_row).each do |number|
+      row = table.row(number)
+      check_data = (row[0].is_a?(String) && row[6].is_a?(Numeric) && row[8].is_a?(Numeric)) &&
+       (row[12].is_a?(Numeric) && row[14].is_a?(Numeric) && row[16].is_a?(Numeric) && row[18].is_a?(Numeric))


Make 6..18 constant array

RGBD · 2019-01-10T08:43:12Z

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.log

@@ -0,0 +1,13 @@
+# Logfile created on 2019-01-10 00:05:53 +0300 by logger.rb/61378


add log to .gitignore

RGBD · 2019-01-10T08:50:54Z

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

+    (9..table.last_row).each do |number|
+      row = table.row(number)
+      check_data = (row[0].is_a?(String) && row[6].is_a?(Numeric) && row[8].is_a?(Numeric)) &&
+                   (row[12].is_a?(Numeric) && row[14].is_a?(Numeric) && row[16].is_a?(Numeric) && row[18].is_a?(Numeric))


use constants instead of literal 8..18

RGBD · 2019-01-10T08:58:04Z

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

+  end
+
+  def perform_data
+    File.new('test.db', 'a')


Remove line. If you really need this file to exist, touch it: FileUtils.touch

RGBD · 2019-01-10T09:02:22Z

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

+  end
+
+  def request
+    check_record


remove line

RGBD · 2019-01-10T09:04:50Z

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

+class DbRequester
+  def initialize(product_name)
+    @product_name = product_name
+    @db = SQLite3::Database.open 'test.db'


Make filename common constant for all files (this and data_parser).

RGBD · 2019-01-10T09:05:22Z

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

+  end
+
+  def similar_price
+    str = @product_name.downcase


remove line

RGBD · 2019-01-10T09:05:52Z

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

+  def similar_price
+    str = @product_name.downcase
+    response = @db.execute "SELECT DISTINCT Name FROM Items WHERE Price < '#{@last_time_cost + 0.5}' AND Price > '#{@last_time_cost - 0.5}' LIMIT(2)"
+    record = response.last


useless assignment, remove line

RGBD · 2019-01-10T09:06:18Z

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

+    str = @product_name.downcase
+    response = @db.execute "SELECT * FROM Items WHERE Name LIKE '#{str} %' ORDER BY Date DESC LIMIT(1)"
+    record = response.last
+    date = revert_unix_date(record.last)


useless assignment

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta_Shved/Elizaveta Shved : 0 :/db_requester.rb

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

elishved · 2019-01-22T13:38:10Z

@RGBD, please review my pr

RGBD · 2019-01-22T21:39:06Z

👍 well done! Now few more fixes:
remove xls, xlsx files from pull request (git rm --cached data/*)
Rename directories so that your homework is located under "Elizaveta Shved/0/"

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Elizaveta Shved/0/download_sheets.rb

Elizaveta Shved/0/db_requester.rb

Elizaveta Shved/0/data_parser.rb

elishved · 2019-01-24T20:22:04Z

@RGBD, please review my pr

RGBD · 2019-01-27T22:17:58Z

.gitignore

@@ -1,3 +1,7 @@
 .DS_Store
 *.mov
 .idea
+test.db


Do NOT touch global gitignore

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

RGBD

You pull request deletes global readme.md. Please, revert that change

RGBD · 2019-02-01T13:34:04Z

.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 *.mov
 .idea
+


Your pull request MUST NOT change global gitignore

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

add task realisation

f7267d5

houndci-bot reviewed Dec 9, 2018

View reviewed changes

Remove unnecessary code. Clear code

b6ebd01

houndci-bot reviewed Dec 9, 2018

View reviewed changes

Clear code

4bc09fb

houndci-bot reviewed Dec 9, 2018

View reviewed changes

Clear code

d9e582a

houndci-bot reviewed Dec 9, 2018

View reviewed changes

Clear code

7b2122c

houndci-bot reviewed Dec 9, 2018

View reviewed changes

Clear code

a2e931a

houndci-bot reviewed Dec 9, 2018

View reviewed changes

RGBD self-assigned this Dec 10, 2018

RGBD requested changes Dec 10, 2018

View reviewed changes

Evshved reviewed Dec 10, 2018

View reviewed changes

Clear

0b070ae

houndci-bot reviewed Dec 10, 2018

View reviewed changes

Clear

3dfc96c

houndci-bot reviewed Dec 10, 2018

View reviewed changes

Nocogiri

934fe1d

houndci-bot reviewed Jan 1, 2019

View reviewed changes

added file in .gitignore

56baf47

houndci-bot reviewed Jan 8, 2019

View reviewed changes

Elizaveta_Shved/Elizaveta Shved : 0 :/data_parser.rb Outdated Show resolved Hide resolved

New constants and iterations

3acc415

houndci-bot reviewed Jan 8, 2019

View reviewed changes

Fix rubocop issues

4bf4ee0

houndci-bot reviewed Jan 8, 2019

View reviewed changes

Remove unnecessary code. Fix linter issues.

67cc7fd

houndci-bot reviewed Jan 9, 2019

View reviewed changes

RGBD requested changes Jan 10, 2019

View reviewed changes

Сorrected version

f863674

houndci-bot reviewed Jan 21, 2019

View reviewed changes

Fix rubocop issues

83692eb

houndci-bot reviewed Jan 21, 2019

View reviewed changes

Fix issues

7a64cd2

houndci-bot reviewed Jan 21, 2019

View reviewed changes

Fix rubocop issues

e552a14

houndci-bot reviewed Jan 22, 2019

View reviewed changes

RGBD added the merge ready approved by mentor label Jan 22, 2019

Delete unnecessary files

40edb65

houndci-bot reviewed Jan 24, 2019

View reviewed changes

RGBD requested changes Jan 27, 2019

View reviewed changes

.gitignore Outdated

@@ -1,3 +1,7 @@

.DS_Store

*.mov

.idea

test.db

Copy link

Collaborator

RGBD Jan 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do NOT touch global gitignore

Fix review

23476dc

houndci-bot reviewed Jan 27, 2019

View reviewed changes

Local .gitignore

f0db675

houndci-bot reviewed Jan 28, 2019

View reviewed changes

RGBD requested changes Feb 1, 2019

View reviewed changes

add README.md

428a448

houndci-bot reviewed Feb 1, 2019

View reviewed changes

		@@ -0,0 +1,13 @@
		# Logfile created on 2019-01-10 00:05:53 +0300 by logger.rb/61378

Elizaveta Shved - 0 #38

Are you sure you want to change the base?

Elizaveta Shved - 0 #38

Conversation

elishved commented Dec 9, 2018

Name

Homework#

Comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

RGBD left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

RGBD commented Dec 28, 2018

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RGBD commented Jan 7, 2019

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

elishved commented Jan 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

elishved commented Jan 22, 2019

RGBD commented Jan 22, 2019

houndci-bot left a comment

Choose a reason for hiding this comment

elishved commented Jan 24, 2019

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

RGBD left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment