-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rules and recommendations from betterspecs.org #55
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c19f746
Pick "describe the methods" rule from betterspecs
andreareginato a68e91e
Pick "use contexts" rule from betterspecs
andreareginato 049fd35
Pick "short descriptions" rule from betterspecs
andreareginato 2e20a2f
Pick "expect vs should" rule from betterspecs
andreareginato f13c341
Pick "use subject" rule from betterspecs
andreareginato 35ed5e0
Pick "use `let` and `let!`" rule from betterspecs
andreareginato da28811
Pick "only needed data" rule from betterspecs
andreareginato c8cabf3
Pick "use factories" rule from betterspecs
andreareginato a08b65f
Pick "easy to read matchers" rule from betterspecs
andreareginato 7a19db1
Pick "shared examples" rule from betterspecs
andreareginato c86d261
Pick "test what you see" rule from betterspecs
andreareginato a3ed17e
Pick "don't use should" rule from betterspecs
andreareginato 17eac42
Pick "stub HTTP requests" rule from betterspecs
andreareginato a64f2ca
Pick "use guard" recommendation from betterspecs
andreareginato a59f456
Pick "formatter" recommendation from betterspecs
andreareginato acbbf0b
Pick "preloading" recommendation from betterspecs
andreareginato 6138c63
Add credit to Andrea and Lelylan for betterspecs
pirj bd02acf
Formatting fix
pirj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the
ModelName.create
example is specific to Rails. Should we consider moving this section down toRails - models
section, or perhaps just add a note in the text?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording implies Rails, but the advice itself is quite generic. Fixtures here are some objects kept in an storage, not even necessarily database. Also:
I'd rather keep the rule in this section, but changed
ModelName.create
into something that applies both to ActiveRecord and, say, file system.