Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use edge RuboCop for internal_investigation task #1

Closed

Conversation

koic
Copy link
Member

@koic koic commented May 12, 2020

This configuration reproduces internal_investigation task of rubocop-hq/rubocop repo.

This configuration reproduces `internal_investigation` task of
rubocop-hq/rubocop repo.
@marcandre
Copy link
Contributor

Thanks for checking this out.

I feel it's best not to add rubocop as a dependency to be sure that rubocop-ast is well self-containted.

Bundler setups all dependencies so it would be hard to detect if the rubocop-ast gem was actually requiring some code from the main rubocop gem. Specs would pass, but the gem wouldn't actually be self contained and anyone requiring just this gem could have their code crash...

@koic
Copy link
Member Author

koic commented May 12, 2020

Ah... sure! rubocop-ast will be a widely used gem outside the RoboCop core. I misunderstood this gem as part of RuboCop 💦 Thank you for gemify and explanation!

@koic koic closed this May 12, 2020
@koic koic deleted the use_edge_rubocop_for_internal_investigation branch May 12, 2020 07:03
@marcandre
Copy link
Contributor

😆 Not sure it will be widely used outside of RuboCop, but the goal is that it can be used separately 😸

I will add a note in the gemspec and Gemfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants