Add pattern method for AST::InPatternNode
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `pattern` method for `AST::InPatternNode`.
|
Thanks! Release in 1.7.0 👍 |
|
Wow! Thank you for your quick release! |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 29, 2021
This PR adds new `Style/InPatternThen` cop. It checks for `in;` uses in `case` expressions. ```ruby # bad case expression in pattern_a; foo in pattern_b; bar end # good case expression in pattern_a then foo in pattern_b then bar end ``` This cop is similar to `Style/WhenThen`, but with different supported syntax and Ruby version (requires 2.7 or higher). And this PR use rubocop/rubocop-ast#186 feature, so it requires RuboCop AST 1.7.0 or higher.
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
May 30, 2021
This PR adds new `Style/InPatternThen` cop. It checks for `in;` uses in `case` expressions. ```ruby # bad case expression in pattern_a; foo in pattern_b; bar end # good case expression in pattern_a then foo in pattern_b then bar end ``` This cop is similar to `Style/WhenThen`, but with different supported syntax and Ruby version (requires 2.7 or higher). And this PR use rubocop/rubocop-ast#186 feature, so it requires RuboCop AST 1.7.0 or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
patternmethod forAST::InPatternNode.