Fix RuboCop::AST::DefNode#void_context? to handle class methods called initialize

[vlad-pisanov]

Currently, DefNode#void_context? incorrectly returns true for class methods called initialize. This PR fixes this.

# constructor: void context ✔️ 
def initialize
  42
end

# class method: not void context! ❌ 
def self.initialize
  42
end

[Earlopain]

Conceptually this makes sense to me, though I wonder if would be better to instead introduce a DefsNode instead which then overrides this method. Not sure if worth the effort, lets wait on other input

[vlad-pisanov]

I actually thought DefsNode was already defined going into this.

I'd rather not make drastic changes in this PR. This is a pre-existing pattern (used in BlockNode for example):

rubocop-ast/lib/rubocop/ast/node/block_node.rb

Line 49 in 30439db

if numblock_type?

[Earlopain]

Ah, right. Yeah, probably fine then. I did a quick search around but didn't find other nodes that did it like this but clearly I didn't search good enough.

[marcandre]

Sorry for the delay, I missed the notification.

Thanks for the PR 👍

My cell phone just died on me, so I can't release right now, but will in a few days.

[koic]

@marcandre If you’d like, I can go ahead and handle the release. Shall I handle the release?

[marcandre]

Sure, that'd be great, thanks @koic ❤️

[koic]

RuboCop AST 1.32.3 has been released. I hope your cell phone gets fixed soon :-)
https://rubygems.org/gems/rubocop-ast/versions/1.32.3