NodePattern: Allow full expressions as function arguments #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
node_pattern_arg
branch
from
cf4009e
to
18722da
Compare
Merged
marcandre
force-pushed
the
node_pattern_arg
branch
2 times, most recently
from
719f5d1
to
bd3102c
Compare
bbatsov
reviewed
Jul 12, 2020
| @@ -316,6 +316,30 @@ We can use the `#prime?` method directly in the expression: | |||
| (int #prime?) | |||
| ---- | |||
|
|
|||
| == Arguments for predicate and external methods | |||
There was a problem hiding this comment.
predicates and external methods? I'm confused by this terminology. :-)
There was a problem hiding this comment.
Right, I'll replace "external methods" with "funcall", which is what is used elsewhere (predicate?, #funcall)
|
Looks cool to me. I only find the terminology confusing - e.g. what's special about predicate methods. |
marcandre
force-pushed
the
node_pattern_arg
branch
from
bd3102c
to
2a3b8ba
Compare
marcandre
force-pushed
the
node_pattern_arg
branch
from
2a3b8ba
to
84f1a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.