Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Ruby 2.4, Set#=== is harmonized with Ruby 2.5+ to call include? #94

Merged
merged 1 commit into from
Aug 16, 2020
Merged

In Ruby 2.4, Set#=== is harmonized with Ruby 2.5+ to call include? #94

merged 1 commit into from
Aug 16, 2020

Conversation

marcandre
Copy link
Contributor

This makes it possible to use Set in NodePattern on all supported Ruby versions.

cc @bbatsov

@marcandre marcandre requested a review from bbatsov August 11, 2020 17:50
bbatsov
bbatsov reviewed Aug 16, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -9,6 +9,10 @@
* [#89](https://github.com/rubocop-hq/rubocop-ast/pull/89): Support right hand assignment for Ruby 2.8 (3.0) parser. ([@koic][])
* [#93](https://github.com/rubocop-hq/rubocop-ast/pull/93): Add `Node#{left|right}_sibling{s}` ([@marcandre][])

### Changes

* [#x](https://github.com/rubocop-hq/rubocop-ast/issue/x): In Ruby 2.4, `Set#===` is harmonized with Ruby 2.5+ to call `include?`. ([@marcandre][])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update this. :-)

@mergify mergify bot merged commit 5b0eb14 into rubocop:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbatsov bbatsov bbatsov approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcandre @bbatsov