Import rubocop test harness, use it

This moves most tests to run inline instead of spawning an extra process. This isn't only faster but also much more explicit in what is actually being tested against. A few tests are left intact for issues that actually manifested during live rubocop runs.
rubocop · Dec 13, 2023 · 8a32f40 · 8a32f40
1 parent 061e331
commit 8a32f40
Show file tree

Hide file tree

Showing 17 changed files with 638 additions and 430 deletions.
diff --git a/lib/rubocop/markdown/preprocess.rb b/lib/rubocop/markdown/preprocess.rb
@@ -39,11 +39,15 @@ class << self
         # using preproccessed source buffer.
         #
         # We have to restore it.
-        def restore!(file)
+        def restore_and_save!(file)
           contents = File.read(file)
-          contents.gsub!(/^##{MARKER}/m, "")
+          restore!(contents)
           File.write(file, contents)
         end
+
+        def restore!(src)
+          src.gsub!(/^##{MARKER}/m, "")
+        end
       end
 
       attr_reader :config

diff --git a/lib/rubocop/markdown/rubocop_ext.rb b/lib/rubocop/markdown/rubocop_ext.rb
@@ -67,7 +67,7 @@ def file_finished(file, offenses)
 
     # Run Preprocess.restore if file has been autocorrected
     if @options[:auto_correct] || @options[:autocorrect]
-      RuboCop::Markdown::Preprocess.restore!(file)
+      RuboCop::Markdown::Preprocess.restore_and_save!(file)
     end
 
     super(file, offenses)

diff --git a/test/fixtures/NON_CODE_OFFENSES.md b/test/fixtures/NON_CODE_OFFENSES.md
diff --git a/test/fixtures/backticks.md b/test/fixtures/backticks.md
diff --git a/test/fixtures/configs/no_autodetect.yml → test/fixtures/configs/config.yml b/test/fixtures/configs/no_autodetect.yml → test/fixtures/configs/config.yml
@@ -1,4 +1 @@
 inherit_from: "../../../.rubocop.yml"
-
-Markdown:
-  Autodetect: false
diff --git a/...es/configs/no_autodetect_with_require.yml → .../fixtures/configs/config_with_require.yml b/...es/configs/no_autodetect_with_require.yml → .../fixtures/configs/config_with_require.yml
@@ -2,6 +2,3 @@ inherit_from: "../../../.rubocop.yml"
 
 require:
   - "rubocop-md"
-
-Markdown:
-  Autodetect: false
diff --git a/test/fixtures/configs/no_warn_invalid.yml b/test/fixtures/configs/no_warn_invalid.yml
diff --git a/test/fixtures/configs/no_warn_invalid_with_require.yml b/test/fixtures/configs/no_warn_invalid_with_require.yml
diff --git a/test/fixtures/in_flight_parse.rb b/test/fixtures/in_flight_parse.rb
diff --git a/test/fixtures/multiple_invalid_snippets.md b/test/fixtures/multiple_invalid_snippets.md
diff --git a/test/fixtures/multiple_invalid_snippets_unknown.md b/test/fixtures/multiple_invalid_snippets_unknown.md
diff --git a/test/fixtures/multiple_snippets.markdown b/test/fixtures/multiple_snippets.markdown