Fixes the case, when config_store is nil #24
Conversation
This problem appeared when "rubocop-md" loaded via .rubocop.yml and used "--formater" Fixes rubocop#22
prog-supdex
changed the title
| Rake::Task[:rubocop_md_tests].reenable | ||
| Rake::Task[:rubocop_md_tests].invoke |
There was a problem hiding this comment.
We should define individual tasks and then an aggregate using Rake dependencies.
The main reason is that we need a way to run each mode individually.
| @@ -11,4 +11,15 @@ end | |||
|
|
|||
| RuboCop::RakeTask.new | |||
|
|
|||
| task :test do | |||
| ENV["MD_LOAD_MODE"] = "inline" | |||
| $stdout.puts "⚙️ Runs rubocop with '-r rubocop_md' options" | |||
There was a problem hiding this comment.
Adding notifications is good idea, but no in the Rakefile. It should be a part of the test suite, so it doesn't depend on the way we run tests (via Rake, via Ruby, or whatever). Having notification here can result in false positives when the actual test suite is not using this env var.
| @@ -2,7 +2,7 @@ require "bundler/gem_tasks" | |||
| require "rake/testtask" | |||
| require "rubocop/rake_task" | |||
|
|
|||
| Rake::TestTask.new(:test) do |t| | |||
| Rake::TestTask.new(:rubocop_md_tests) do |t| | |||
There was a problem hiding this comment.
Why prefixing with rubocop_md? This is the Rakefile for the project, so theme is implied.
| def cmd_command_by_env(path, options) | ||
| cmd_command = "bundle exec rubocop" | ||
| load_mode = ENV.fetch("MD_LOAD_MODE", MD_LOAD_INLINE_MODE) | ||
|
|
||
| if load_mode == MD_LOAD_INLINE_MODE | ||
| md_path = File.expand_path("../lib/rubocop-md.rb", __dir__) | ||
|
|
||
| cmd_command = "#{cmd_command} -r #{md_path}" | ||
| end | ||
|
|
||
| "#{cmd_command} #{options} #{path}" | ||
| end | ||
| end |
There was a problem hiding this comment.
This is an example of improper usage of the extract method pattern. It breaks cohesion; previously, the code related to the command generation was in a single place; now, we have it spread across the file and we lose the context (what is -r, where it comes from)?
Longer methods are sometimes (quite often) better.
This problem appeared when
rubocop-mdloaded via.rubocop.ymland used--formaterbecause theRunneris created before plugins (rubocop_ext) is loaded.Fixes #22
Also, I rewrote the running test through the
requiresection in.rubocop.yml.