Fix incompatibility with RuboCop extensions that modify Include/Exclude for cops #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de for cops Consider this example: * A different extension (like rubocop-erb) gets loaded first and modifies a cops Exclude list * rubocop-md gets loaded and also modifies the same cops exclude list * rubocop-md discards the changes from rubocop-erb because the configs aren't being merged
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this:
For example, when adding rubocop-erb to the rails repository there are about 1.5k offenses. With this change there are only about 10% since the excludes from rubocop-erb are properly applied.
I tried adding a test for this but couldn't figure out how to do that properly.
CI for ruby-head is failing until minitest releases a new version, see minitest/minitest@5f5c211