Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #140] Make AssertNil and RefuteNil aware of assert(obj.nil?) #141

Conversation

koic
Copy link
Member

@koic koic commented Aug 6, 2021

Fixes #140.

This PR makes Minitest/AssertNil and Minitest/RefuteNil aware of assert(obj.nil?) and refute(obj.nil?).


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…bj.nil?)`

Fixes rubocop#140.

This PR makes `Minitest/AssertNil` and `Minitest/RefuteNil` aware of
`assert(obj.nil?)` and `refute(obj.nil?)`.
@koic koic merged commit 118799c into rubocop:master Aug 7, 2021
@koic koic deleted the make_assert_nil_and_refute_nil_aware_of_assert_method branch August 7, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cop Feature Request: Catch assert expression.nil? and suggest assert_nil instead
1 participant