Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire Performance/ArraySemiInfiniteRangeSlice cop #198

Open
marcandre opened this issue Nov 23, 2020 · 5 comments
Open

Retire Performance/ArraySemiInfiniteRangeSlice cop #198

marcandre opened this issue Nov 23, 2020 · 5 comments
Milestone
2.0

Comments

@marcandre
Copy link
Contributor

This cop was created due to a mistake in the microbenchmark.

I would like to repeat: if there is no fundamental reason why something is slower, then... it might not be, or there might be a bug.
@tejasbubane
Copy link
Contributor

rubocop has config_obsoletion class which allows removal of code.

What is the process to retire cops here? Do we just disable the cop from default.yml?

@marcandre marcandre mentioned this issue Nov 23, 2020
Merged
8 tasks
@marcandre
Copy link
Contributor Author

marcandre commented Nov 23, 2020 •
edited
Loading

I don't know tbh. I note that these constants are not frozen 😈 I imagine that disabling it by default and commenting in the doc is the way to go...

tejasbubane added a commit to tejasbubane/rubocop-performance that referenced this issue Nov 23, 2020
@tejasbubane
[Fix rubocop#197] Disable Performance/ArraySemiInfiniteRangeSlice cop
4620f29 
This cop was created due to a mistake in microbenchmark
Refer rubocop#175 (comment)

Closes rubocop#197, rubocop#198
tejasbubane added a commit to tejasbubane/rubocop-performance that referenced this issue Nov 23, 2020
@tejasbubane
[Fix rubocop#197] Disable Performance/ArraySemiInfiniteRangeSlice cop
5f60d7c 
This cop was created due to a mistake in microbenchmark
Refer rubocop#175 (comment)

Closes rubocop#197, rubocop#198
tejasbubane added a commit to tejasbubane/rubocop-performance that referenced this issue Nov 23, 2020
@tejasbubane
[Fix rubocop#197] Disable Performance/ArraySemiInfiniteRangeSlice cop
2d4834c 
This cop was created due to a mistake in microbenchmark
Refer rubocop#175 (comment)

Closes rubocop#197, rubocop#198
tejasbubane added a commit to tejasbubane/rubocop-performance that referenced this issue Nov 24, 2020
@tejasbubane
[Fix rubocop#197] Disable Performance/ArraySemiInfiniteRangeSlice cop
0a382e8 
This cop was created due to a mistake in microbenchmark
Refer rubocop#175 (comment)

Closes rubocop#197, rubocop#198
tejasbubane added a commit to tejasbubane/rubocop-performance that referenced this issue Nov 24, 2020
@tejasbubane
[Fix rubocop#197] Disable Performance/ArraySemiInfiniteRangeSlice cop
8a9eaa4 
This cop was created due to a mistake in microbenchmark
Refer rubocop#175 (comment)

Closes rubocop#197, rubocop#198
tejasbubane added a commit to tejasbubane/rubocop-performance that referenced this issue Nov 24, 2020
@tejasbubane
[Fix rubocop#197] Disable Performance/ArraySemiInfiniteRangeSlice cop
7503710 
This cop was created due to a mistake in microbenchmark
Refer rubocop#175 (comment)

Closes rubocop#197, rubocop#198
@tejasbubane
Copy link
Contributor

This can be closed via #199

@koic
Copy link
Member

koic commented Nov 25, 2020 •
edited
Loading

I'd like to plan to remove this cop in the future RuboCop Performance 2.0. And any approach that does not cause breaking change needs to be considered. I will leave this issue until then.

@koic koic added this to the 2.0 milestone Nov 25, 2020
@koic koic mentioned this issue Nov 30, 2020
Merged
@jmkoni jmkoni mentioned this issue Nov 30, 2020
Merged
@marcandre marcandre mentioned this issue Nov 30, 2020
Closed
@marcandre
Copy link
Contributor Author

I opened an issue on RuboCop's side for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@koic @marcandre @tejasbubane