Require RuboCop 1.7 or higher due to support obsoletion configuration #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow rubocop/rubocop#9206 and rubocop/rubocop#9143. This PR requires RuboCop 1.7 or higher due to support obsoletion configuration and reverts rubocop@0e59891.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Apr 21, 2021
This PR reverts rubocop@b15e034. The following tests will fail depending on the run tests sequence when using RuboCop Performance to 1.11.0. ```console % bundle exec rspec --seed 33314 ./spec/rubocop/config_obsoletion_spec.rb Run options: include {:focus=>true} All examples were filtered out; ignoring {:focus=>true} Randomized with seed 33314 ....F.... Failures: 1) RuboCop::ConfigObsoletion#validate when the configuration includes any extracted cops when the extensions are not loaded prints a warning message Failure/Error: expect(expected_message).to eq(e.message) expected: "`Rails` cops have been extracted to the `rubocop-rails` gem.\n(obsolete configuration found in example/.rubocop.yml, please update it)" got: "`Performance` cops have been extracted to the `rubocop-performance` gem.\n(obsolete configuration fo... the `rubocop-rails` gem.\n(obsolete configuration found in example/.rubocop.yml, please update it)" (compared using ==) Diff: @@ -1,2 +1,4 @@ +`Performance` cops have been extracted to the `rubocop-performance` gem. +(obsolete configuration found in example/.rubocop.yml, please update it) `Rails` cops have been extracted to the `rubocop-rails` gem. (obsolete configuration found in example/.rubocop.yml, please update it) # ./spec/rubocop/config_obsoletion_spec.rb:269:in `rescue in block (5 levels) in <top (required)>' # ./spec/rubocop/config_obsoletion_spec.rb:266:in `block (5 levels) in <top (required)>' # ./lib/rubocop/rspec/shared_contexts.rb:30:in `block (4 levels) in <top (required)>' # ./lib/rubocop/rspec/shared_contexts.rb:30:in `chdir' # ./lib/rubocop/rspec/shared_contexts.rb:30:in `block (3 levels) in <top (required)>' # ./lib/rubocop/rspec/shared_contexts.rb:7:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # RuboCop::ValidationError: # `Rails` cops have been extracted to the `rubocop-rails` gem. # (obsolete configuration found in example/.rubocop.yml, please update it) # ./lib/rubocop/config_obsoletion.rb:43:in `reject_obsolete!' Finished in 0.16954 seconds (files took 0.94235 seconds to load) 9 examples, 1 failure Failed examples: rspec ./spec/rubocop/config_obsoletion_spec.rb:265 # RuboCop::ConfigObsoletion#validate when the configuration includes any extracted cops when the extensions are not loaded prints a warning message Randomized with seed 33314 ``` RuboCop Performance upgrade to 1.11 is postponed until this test will be stable in this repository. rubocop/rubocop-performance#235 is RuboCop Performance change related to the build error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rubocop/rubocop#9206 and rubocop/rubocop#9143.
This PR requires RuboCop 1.7 or higher due to support obsoletion configuration and reverts 0e59891.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.