Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from AutoCorrect: false to SafeAutoCorrect: false for Performance/TimesMap #275

Conversation

koic
Copy link
Member

@koic koic commented Nov 28, 2021

Follow up to rubocop/rubocop#6177.

This AutoCorrect: false looks like it was set when there was no way to safe autocorrect by SafeAutocorrect: false.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…formance/TimesMap`

Follow up to rubocop/rubocop#6177.

This `AutoCorrect: false` looks like it was set when there was no way to
safe autocorrect by `SafeAutocorrect: false`.
@koic koic merged commit 16833a0 into rubocop:master Dec 3, 2021
@koic koic deleted the change_unmark_autocorrect_false_from_performance_times_map branch December 3, 2021 16:23
koic added a commit that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant