Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort! and minmax to Performance/CompareWithBlock #357

Merged
merged 1 commit into from
May 10, 2023

Conversation

vlad-pisanov
Copy link
Contributor

Performance/CompareWithBlock currently only looks at sort, min and max usage.

This PR adds support for sort! and minmax methods which behave the same way.

# bad
arr.minmax { |a, b| a.foo <=> b.foo }
arr.sort!  { |a, b| a.foo <=> b.foo }

# good
arr.minmax_by(&:foo)
arr.sort_by!(&:foo)
Comparison:
               minmax_by:  1513625.0 i/s
               minmax:     1178249.9 i/s - 1.28x  slower
Comparison:
               sort_by!:    21368.8 i/s
               sort!:       13662.7 i/s - 1.56x  slower

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit ac57a77 into rubocop:master May 10, 2023
@koic
Copy link
Member

koic commented May 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants