Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negatives for Performance/StringIdentifierArgument #428

Conversation

koic
Copy link
Member

@koic koic commented Dec 23, 2023

This PR fixes false negatives for Performance/StringIdentifierArgument when using multiple string arguments.

e.g., alias_method 'new', 'original'


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_false_negatives_make_performance_string_identifier_argument branch from 9381eea to 805f387 Compare December 23, 2023 08:31
This PR fixes false negatives for `Performance/StringIdentifierArgument`
when using multiple string arguments.

e.g., `alias_method 'new', 'original'`
@koic koic force-pushed the fix_false_negatives_make_performance_string_identifier_argument branch from 805f387 to 98ca79d Compare December 23, 2023 13:57
@koic koic merged commit d7813f5 into rubocop:master Dec 25, 2023
12 checks passed
@koic koic deleted the fix_false_negatives_make_performance_string_identifier_argument branch December 25, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant