Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Performance/StartWith and Performance/EndWith correct Regexp#match and Regexp#=~ #82

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

eugeneius
Copy link
Contributor

Support for String#match? was added in rubocop/rubocop#5744, but not Regexp#match?.

Calling =~ on a regex literal generates a specialised AST node, match-with-lvasgn, to support assigning named captures as local variables. The pattern would previously never match this usage.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…h? and Regexp#=~

Support for `String#match?` was added in
3027c87, but not `Regexp#match?`.

Calling `=~` on a regex literal generates a specialised AST node,
`match-with-lvasgn`, to support assigning named captures as local
variables. The pattern would previously never match this usage.
@koic koic merged commit 1090cb0 into rubocop:master Oct 28, 2019
@koic
Copy link
Member

koic commented Oct 28, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants