Merge pull request #1061 from koic/fix_a_false_positive_for_rails_htt…

…p_status [Fix #1060] Fix a false positive for `Rails/HttpStatus`
rubocop · Aug 4, 2023 · 541da7c · 541da7c
2 parents 9bb121a + ddd4a80
commit 541da7c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_a_false_positive_for_rails_http_status.md b/changelog/fix_a_false_positive_for_rails_http_status.md
@@ -0,0 +1 @@
+* [#1060](https://github.com/rubocop/rubocop-rails/issues/1060): Fix a false positive for `Rails/HttpStatus` when using symbolic value that have no numeric value mapping. ([@koic][])
diff --git a/lib/rubocop/cop/rails/http_status.rb b/lib/rubocop/cop/rails/http_status.rb
@@ -133,7 +133,7 @@ def initialize(node)
           end
 
           def offensive?
-            !node.int_type? && !permitted_symbol?
+            !node.int_type? && !permitted_symbol? && number
           end
 
           def message

diff --git a/spec/rubocop/cop/rails/http_status_spec.rb b/spec/rubocop/cop/rails/http_status_spec.rb
@@ -125,5 +125,11 @@
         render :foo, status: :redirect
       RUBY
     end
+
+    it 'does not register an offense when using symbolic value that have no numeric value mapping' do
+      expect_no_offenses(<<~RUBY)
+        render json: { foo: 'bar' }, status: :ng
+      RUBY
+    end
   end
 end
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#1060](https://github.com/rubocop/rubocop-rails/issues/1060): Fix a false positive for `Rails/HttpStatus` when using symbolic value that have no numeric value mapping. ([@koic][])