-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive for Rails/ActionControllerFlashBeforeRender
when using return redirect_to
#1244
Comments
Earlopain
added a commit
to Earlopain/rubocop-rails
that referenced
this issue
Mar 4, 2024
…ashBeforeRender` when returning `redirect_to`
9 tasks
Earlopain
added a commit
to Earlopain/rubocop-rails
that referenced
this issue
Mar 4, 2024
…ashBeforeRender` when returning `redirect_to`
koic
added a commit
that referenced
this issue
Mar 4, 2024
[Fix #1244] Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when returning `redirect_to`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
When exiting an action early, we often use
return redirect_to ...
, since the return value doesn't matter, and it saves a line. Unfortunately, this can trigger an offense.Actual behavior
Steps to reproduce the problem
RuboCop version
The text was updated successfully, but these errors were encountered: