-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails/RakeEnvironment false positive when using Capistrano #206
Labels
bug
Something isn't working
Comments
Good point. I think this cop should ignore |
Thanks for the feedback. I agree with @pocke. |
sinsoku
added a commit
to sinsoku/rubocop-rails
that referenced
this issue
Feb 28, 2020
It excludes the directory where Capistrano tasks are located. Because these tasks don't need to invoke the `:environment` task, and the directory structure is the official way. ref: https://github.com/capistrano/capistrano/tree/v3.12.0#capify-your-project Fixes rubocop#206
sinsoku
added a commit
to sinsoku/rubocop-rails
that referenced
this issue
Feb 28, 2020
…en using Capistrano It excludes the directory where Capistrano tasks are located. Because these tasks don't need to invoke the `:environment` task, and the directory structure is the official way. ref: https://github.com/capistrano/capistrano/tree/v3.12.0#capify-your-project Fixes rubocop#206
8 tasks
sinsoku
added a commit
to sinsoku/rubocop-rails
that referenced
this issue
Feb 28, 2020
…en using Capistrano It excludes the directory where Capistrano tasks are located. Because these tasks don't need to invoke the `:environment` task, and the directory structure is the official way. ref: https://github.com/capistrano/capistrano/tree/v3.12.0#capify-your-project Fixes rubocop#206
koic
added a commit
that referenced
this issue
Feb 28, 2020
[Fix #206] Fix a false positive for `Rails/RakeEnvironment` when using Capistrano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For projects using Capistrano, we create rake files in
lib/capistrano/tasks/*.rake
.In these files we do not need to invoke the
:environment
task.Expected behavior
The Cop should not be offense.
Actual behavior
Save the following file as
lib/capistrano/tasks/sidekiq.rake
.Then run RuboCop.
RuboCop version
0.79.0 (using Parser 2.7.0.2, running on ruby 2.6.5 x86_64-darwin19)
The text was updated successfully, but these errors were encountered: