Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/RedundantSafeNavigation aware of several methods #1014

Conversation

koic
Copy link
Member

@koic koic commented May 27, 2023

This PR makes Lint/RedundantSafeNavigation aware of blank?, presence, and present? methods.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR makes `Lint/RedundantSafeNavigation` aware of
`blank?`, `presence`, and `present?` methods.
@koic koic force-pushed the make_lint_redundant_safe_navigation_aware_of_several_methods branch from 1cc6da9 to 4052e55 Compare May 27, 2023 06:16
@koic koic merged commit 101e691 into rubocop:master May 28, 2023
@koic koic deleted the make_lint_redundant_safe_navigation_aware_of_several_methods branch May 28, 2023 05:02
koic added a commit that referenced this pull request Jun 2, 2023
Follow up #1014.

This commit fixes a false positive for `Lint/RedundantSafeNavigation`
when using `blank?`:

```ruby
nil.presence || 42  # => 42
nil&.presence || 42 # => 42

nil.present? || 42  # => 42
nil&.present? || 42 # => 42

nil.blank? || 42    # => true
nil&.blank? || 4    2# => 42
```
@koic
Copy link
Member Author

koic commented Jun 2, 2023

ee3554b fixes the following false positive for Lint/RedundantSafeNavigation when using blank?:

nil.presence || 42  # => 42
nil&.presence || 42 # => 42

nil.present? || 42  # => 42
nil&.present? || 42 # => 42

nil.blank? || 42    # => true
nil&.blank? || 42   # => 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant