Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #120] Fix save-in-conditional checking in Rails/SaveBang #121

Merged
merged 1 commit into from
Sep 17, 2019
Merged

[Fix #120] Fix save-in-conditional checking in Rails/SaveBang #121

merged 1 commit into from
Sep 17, 2019
+47 −14

Commits on Sep 16, 2019

  1. [Fix rubocop#120] Fix save-in-conditional checking in Rails/SaveBang 

    Fixes rubocop#120.

The Rails/SaveBang rule emitted incorrect errors about using the return
value of save-like calls in conditional nodes. It did not differentiate
between such calls in the body versus the condition, where only the
latter is necessarily a boolean expression.
    @jas14
    jas14 committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    f7287a2 View commit details
    Browse the repository at this point in the history