Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/FilePath cop error on join method with implicit receiver #1398

Conversation

viralpraxis
Copy link
Contributor

@viralpraxis viralpraxis commented Dec 21, 2024

echo 'join(Rails.root, path)' | rubocop --only Rails/FilePath  --stdin bug.rb -d

n error occurred while Rails/FilePath cop was inspecting bug.rb:1:0.
undefined method `each_node' for nil
lib/rubocop/cop/rails/file_path.rb:54:in `rails_root_nodes?'
lib/rubocop/cop/rails/file_path.rb:60:in `rails_root_join_nodes?'
lib/rubocop/cop/rails/file_path.rb:108:in `check_for_rails_root_join_with_string_arguments'
lib/rubocop/cop/rails/file_path.rb:70:in `on_send'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

join(Rails.root, path)
RUBY
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test and implementation like this seem to be required for both EnforcedStyle: 'arguments' and EnforcedStyle: 'slashes'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed.

```console
echo 'join(Rails.root, path)' | rubocop --only Rails/FilePath  --stdin bug.rb -d

n error occurred while Rails/FilePath cop was inspecting bug.rb:1:0.
undefined method `each_node' for nil
lib/rubocop/cop/rails/file_path.rb:54:in `rails_root_nodes?'
lib/rubocop/cop/rails/file_path.rb:60:in `rails_root_join_nodes?'
lib/rubocop/cop/rails/file_path.rb:108:in `check_for_rails_root_join_with_string_arguments'
lib/rubocop/cop/rails/file_path.rb:70:in `on_send'
```
@viralpraxis viralpraxis force-pushed the fix-rails-file-path-cop-error-on-join-method-implicit-receiver branch from a1b0618 to 815d119 Compare December 23, 2024 05:46
@koic koic merged commit 2671fb4 into rubocop:master Dec 23, 2024
14 checks passed
@koic
Copy link
Member

koic commented Dec 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants