Fix Rails/FilePath cop error in case of extra operations in Rails.root interpolation
#1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Dec 22, 2024
| it 'does not register an offense' do | ||
| expect_no_offenses(<<~'RUBY') | ||
| "#{Rails.root rescue '.'}/config" | ||
| RUBY | ||
| end | ||
| end | ||
|
|
||
| context 'with addition operations inside `Rails.root` interpolation expression' do |
There was a problem hiding this comment.
The meaning of "addition operations" is unclear. Could you clarify the context of this spec?
There was a problem hiding this comment.
I updated the spec's description, hope it's more clear now.
viralpraxis
force-pushed
the
fix-rails-file-path-cop-error-on-extra-operations-in-rails-root-interpolation
branch
2 times, most recently
from
2f60f06 to
efe2c57
Compare
…root` interpolation Follow-up to rubocop#1392. Previous PR didn't fix cases like this ``` "#{Rails.root || '.'}/config" ``` (it makes sense in real code since `Rails.root` [can be nil](https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L65-L67)) I think it's safe to simply check if the entire expression is of `send` type.
viralpraxis
force-pushed
the
fix-rails-file-path-cop-error-on-extra-operations-in-rails-root-interpolation
branch
from
efe2c57 to
e4aee6b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1392. Previous PR didn't fix cases like this
"#{Rails.root || '.'}/config"(it makes sense in real code since
Rails.rootcan be nil)I think it's safe to simply check if the entire expression is of
sendtype.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.