# Address false positive when reversing remove_foreign_key

[joshpencheon]

The other table can be specified either as the second argument, or in the :to_table key of a hash as the second argument. The latter was not supported.

# was bad, now good:
def change
  remove_foreign_key :accounts, to_table: :branches
end

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[koic]

Can you fix the following failure test?

Failures:

  1) RuboCop Rails Project changelog has link definitions for all implicit links
     Failure/Error:
       expect(changelog.include?("[#{name}]: http"))
         .to be(true), "CHANGELOG.md is missing a link for #{name}. " \
                       'Please add this link to the bottom of the file.'
     
       CHANGELOG.md is missing a link for @joshpencheon. Please add this link to the bottom of the file.
     # ./spec/project_spec.rb:27:in `block (4 levels) in <top (required)>'
     # ./spec/project_spec.rb:26:in `each'
     # ./spec/project_spec.rb:26:in `block (3 levels) in <top (required)>'

Finished in 1.85 seconds (files took 1.32 seconds to load)
2239 examples, 1 failure

https://circleci.com/gh/rubocop-hq/rubocop-rails/2700

You can see also CONTRIBUTING.md:

If this is your first contribution to RuboCop project, add a link definition for the implicit link to the bottom of the changelog as [@username]: https://github.com/username.

https://circleci.com/gh/rubocop-hq/rubocop-rails/2700

[joshpencheon]

Done thanks - sorry, the local suite didn't have that failure.

[koic]

Can you update with squiggly heredoc?

Suggested change

	'remove_foreign_key(with to_table option)', <<-RUBY
	'remove_foreign_key(with to_table option)', <<~RUBY

[joshpencheon]

I found with squiggly heredoc another style rule complained about indentation (see other >80 char workarounds earlier in the file), but have shortened spec label and it fits now.

[koic]

Would you update with the description using :to_table? This suggestion is less than 80 characters :-)

Suggested change

	it_behaves_like 'accepts', 'remove_foreign_key(with table option)', <<~RUBY
	it_behaves_like 'accepts', 'remove_foreign_key(with `:to_table`)', <<~RUBY

[koic]

Thanks!