Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Rails/ApplicationController and similar cops as unsafe autocorrect #223

Merged
merged 1 commit into from
Apr 1, 2020

Commits on Apr 1, 2020

  1. Mark Rails/ApplicationController and similar cops as unsafe autocor…

    …rect
    
    We have a controller class which inherits `ActionController::Base` directly.
    That controller is for health check endpoint.
    
    ```ruby
    class HealthCheckController < ActionController::Base
      # we want to skip some authentication logics...
      def index
        head :ok
      end
    end
    ```
    
    ```ruby
    class ApplicationController < ActionController::Base
      # default some authentication logics...
    end
    ```
    
    In such case, automatically modifying the `ActionController :: Base`->` ApplicationController` is not safe .
    hoshinotsuyoshi committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    a1aa7d5 View commit details
    Browse the repository at this point in the history