Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Rails/MatchRoute cop #275

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Add new Rails/MatchRoute cop #275

merged 1 commit into from
Jun 30, 2020

Conversation

fatkodima
Copy link
Contributor

https://rails.rubystyle.guide/#no-match-routes

# bad
match ':controller/:action/:id'
match 'photos/:id', to: 'photos#show', via: :get

# good
get ':controller/:action/:id'
get 'photos/:id', to: 'photos#show'
match 'photos/:id', to: 'photos#show', via: [:get, :post]
match 'photos/:id', to: 'photos#show', via: :all

@fatkodima
Copy link
Contributor Author

Updated.

andyw8
andyw8 reviewed Jun 29, 2020
View reviewed changes
config/default.yml Outdated Show resolved Hide resolved
koic
koic reviewed Jun 30, 2020
View reviewed changes
config/default.yml Outdated Show resolved Hide resolved
@fatkodima
Copy link
Contributor Author

Updated.

@koic koic merged commit 840f152 into rubocop:master Jun 30, 2020
@koic
Copy link
Member

koic commented Jun 30, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 left review comments

@koic koic koic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatkodima @koic @andyw8