Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rack to runtime dependency #36

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Feb 13, 2019

I'm not sure the status of this repository. So if this pull request is not mergeable now, I think we keep open this pull request.

Rails/HttpStatus cop uses rack gem as an additional dependency to display more descriptive offense messages. The runtime dependencies do not include rack because RuboCop needs the gem only for the cop.

I think we can add rack to runtime dependencies after separating rubocop-rails gem.
rubocop is used without rack sometimes, but rubocop-rails gem will be used with rails gem in most cases, so the environment includes rack already.
If we add rack, installed gems does not increase.

@andyw8
Copy link
Contributor

andyw8 commented Feb 13, 2019

For reference: https://github.com/rubocop-hq/rubocop/issues/5745

@koic koic merged commit dea8939 into rubocop:master Feb 14, 2019
@koic
Copy link
Member

koic commented Feb 14, 2019

This looks useful to me.

I'm not sure the status of this repository.

This repository is WIP. I'm doing a hack like RuboCop::RSpec::Inject now.
rubocop/rubocop#5976 (comment)

I think we can release after that hack (and prepare minimal document) . When releasing, I'd like report again to @toshimaru about repository name.
toshimaru/rubocop-rails#31 (comment)

@pocke pocke deleted the add-runtime-dependency-rack branch February 14, 2019 03:55
@pocke
Copy link
Contributor Author

pocke commented Feb 14, 2019

Thank you for your merging and describing, @koic !
Feel free to tell me if the cop has any problems such as backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants